-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always use programUrl (instead of programName) #300
Conversation
There are a few things I don't like:
|
With "interface", you mean the plugin://plugin.video.vrt.nu/ url? Okay then, I'll look into this to simplify the parameters. |
486691c
to
eedb8aa
Compare
Correct, this is mostly used for autostart or automation, where users are exposed to our interface. That's also why I don't like the current ?action=&video_url= and would prefer the router module and a nice syntax instead. But we can't change it for the existing playable items, as that would make everything already watched unwatched again. So any change to that should be delayed for a v2 release. However for favorites and some of the other actions with a very low probability that they are automated/stored as favorites we have a chance of improving the interface. |
I really like your new implementation, it simplifies quite a few parts of the code. I have two remarks and one concern though:
But maybe we should have this discussion now anyway and make the next release v2 ? |
7b2aa5a
to
e82a84a
Compare
I think it's a good idea to change the target branch of this pull request and merge this to a v2.0 branch. About the |
What you implement is close to my ideal implementation, but because it breaks existing bookmarks/automation I was happy with only the required changes for favorites (and some other interfaces). But now that we have this, maybe we should just bite the bullet and agree on the holistic approach for v2. PS If I would make a v2. branch, we may still need to close this PR and open a new PR against the v2 branch. I would rather not have 2 main branches open for a long period of time though. So I wonder if we even have to do a v1.10.1 release ? (and in case we do, we can easily open a new 1.10 branch for fixing whatever comes our way and keep master to upcoming v2 branch ?) |
I don't know when we will have a good working v2 version, so I think a v1.10.1 branch with bug fixes is needed. We can keep the master branch for v2 development Editing the database is possible and acceptable but unnecessary work. |
e82a84a
to
5e7b391
Compare
Closing this, because this mixes up v1.10.1 and v2 functionality. |
This pull request includes:
programUrl
, longprogramUrl
andtargetUrl
between each other:Examples:
program: de-campus-cup
short
programUrl
: /vrtnu/a-z/de-campus-cup/long
programUrl
: //www.vrt.be/vrtnu/a-z/de-campus-cup/targetUrl:
//www.vrt.be/vrtnu/a-z/de-campus-cup.relevant/